GGLinnk/bees
1
0
Fork 0
mirror of https://github.com/Zygo/bees.git synced 2025-05-17 21:35:45 +02:00
Code Packages

tempfile: drop the fsync()

Browse Source 
The deadlock seems to be fixed now (if there ever was one--there certainly
were deadlocks, but matching deadlocks to root causes is non-trivial
and a number of distinct deadlock cases have been fixed in recent years).

The benchmark data is inconclusive about whether it is better to fsync or
not to fsync.  A paranoia option might be useful here.

Signed-off-by: Zygo Blaxell <bees@furryterror.org>
This commit is contained in:
Zygo Blaxell 2018-11-11 13:16:20 -05:00 committed by Kai Krakow
parent a5b9919d26
commit 5ee09ef9e8
No known key found for this signature in database
GPG Key ID: 046FAC3028D76321
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bees.cc
View File

@ -627,7 +627,7 @@ BeesTempFile::make_copy(const BeesFileRange &src)
// We seem to get lockups without this!
if (did_block_write) {
#if 1
#if 0
// Is this fixed by "Btrfs: fix deadlock between dedup on same file and starting writeback"?
// No.
// Is this fixed in kernel 4.14.34?