From 5ee09ef9e8bed4e2825a034e2615d0738f314b0e Mon Sep 17 00:00:00 2001 From: Zygo Blaxell Date: Sun, 11 Nov 2018 13:16:20 -0500 Subject: [PATCH] tempfile: drop the fsync() The deadlock seems to be fixed now (if there ever was one--there certainly were deadlocks, but matching deadlocks to root causes is non-trivial and a number of distinct deadlock cases have been fixed in recent years). The benchmark data is inconclusive about whether it is better to fsync or not to fsync. A paranoia option might be useful here. Signed-off-by: Zygo Blaxell --- src/bees.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bees.cc b/src/bees.cc index 7d1e543..a7b8dc0 100644 --- a/src/bees.cc +++ b/src/bees.cc @@ -627,7 +627,7 @@ BeesTempFile::make_copy(const BeesFileRange &src) // We seem to get lockups without this! if (did_block_write) { -#if 1 +#if 0 // Is this fixed by "Btrfs: fix deadlock between dedup on same file and starting writeback"? // No. // Is this fixed in kernel 4.14.34?