mirror of
https://github.com/Zygo/bees.git
synced 2025-05-17 21:35:45 +02:00
hash: drop bees_unreadahead
Forcing the entire hash table into immediate writeback causes crippling write latencies at shutdown. Even discarding pages as they are read in at startup can trigger a writeback latency spike if the pages are dirty at read time. Better to let the VM subsystem handle this on its own. Signed-off-by: Zygo Blaxell <bees@furryterror.org>
This commit is contained in:
parent
13ec4b5165
commit
ff3b5a7a1b
@ -206,8 +206,11 @@ BeesHashTable::writeback_loop()
|
||||
}
|
||||
catch_all([&]() {
|
||||
// trigger writeback on our way out
|
||||
#if 0
|
||||
// seems to trigger huge latency spikes
|
||||
BEESTOOLONG("unreadahead hash table size " << pretty(m_size));
|
||||
bees_unreadahead(m_fd, 0, m_size);
|
||||
#endif
|
||||
});
|
||||
BEESLOGDEBUG("Exited hash table writeback_loop");
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user