mirror of
				https://github.com/Zygo/bees.git
				synced 2025-11-04 04:00:36 +01:00 
			
		
		
		
	options: remove default 8 CPU thread limit
Higher CPU core counts became more common, and kernel bugs became less common, since the arbitrary 8-thread limit was introduced. We can remove the limit now, and treat any remaining scaling inefficiency as a bug to be removed. Signed-off-by: Zygo Blaxell <bees@furryterror.org>
This commit is contained in:
		@@ -842,11 +842,6 @@ bees_main(int argc, char *argv[])
 | 
			
		||||
			thread_factor = BEES_DEFAULT_THREAD_FACTOR;
 | 
			
		||||
		}
 | 
			
		||||
		thread_count = max(1U, static_cast<unsigned>(ceil(thread::hardware_concurrency() * thread_factor)));
 | 
			
		||||
		if (thread_count > BEES_DEFAULT_THREAD_LIMIT) {
 | 
			
		||||
			BEESLOGNOTICE("Limiting computed thread count to " << BEES_DEFAULT_THREAD_LIMIT);
 | 
			
		||||
			BEESLOGNOTICE("Use --thread-count to override this limit");
 | 
			
		||||
			thread_count = BEES_DEFAULT_THREAD_LIMIT;
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if (load_target != 0) {
 | 
			
		||||
 
 | 
			
		||||
@@ -86,9 +86,6 @@ const size_t BEES_OPEN_FILE_LIMIT = (BEES_FILE_FD_CACHE_SIZE + BEES_ROOT_FD_CACH
 | 
			
		||||
// Worker thread factor (multiplied by detected number of CPU cores)
 | 
			
		||||
const double BEES_DEFAULT_THREAD_FACTOR = 1.0;
 | 
			
		||||
 | 
			
		||||
// Don't use more than this number of threads unless explicitly configured
 | 
			
		||||
const size_t BEES_DEFAULT_THREAD_LIMIT = 8;
 | 
			
		||||
 | 
			
		||||
// Log warnings when an operation takes too long
 | 
			
		||||
const double BEES_TOO_LONG = 5.0;
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user