From f8c27f5c6a3cf4cd890c1fee2970d3cfae738e86 Mon Sep 17 00:00:00 2001 From: Zygo Blaxell Date: Mon, 23 Apr 2018 15:27:05 -0400 Subject: [PATCH] bees: revert TOXIC_INTERVAL back to pre-4.14 levels Linux kernel 4.14, while resistant to extent toxicity, is not immune to it. Go back to the paranoid setting to avoid tying up filesystems in ridiculously long kernel loops in find_parent_nodes. Signed-off-by: Zygo Blaxell --- src/bees.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bees.h b/src/bees.h index 8027b59..14cb1ce 100644 --- a/src/bees.h +++ b/src/bees.h @@ -89,9 +89,10 @@ const double BEES_DEFAULT_THREAD_FACTOR = 1.0; const double BEES_TOO_LONG = 5.0; // Avoid any extent where LOGICAL_INO takes this long -// const double BEES_TOXIC_DURATION = 9.9; +const double BEES_TOXIC_DURATION = 9.9; // EXPERIMENT: Kernel v4.14+ may let us ignore toxicity -const double BEES_TOXIC_DURATION = 99.9; +// NOPE: kernel 4.14 has the same toxicity problems as any previous kernel +// const double BEES_TOXIC_DURATION = 99.9; // How long between hash table histograms const double BEES_HASH_TABLE_ANALYZE_INTERVAL = BEES_STATS_INTERVAL;