GGLinnk/bees
1
0
Fork 0
mirror of https://github.com/Zygo/bees.git synced 2025-05-17 21:35:45 +02:00
Code Packages

extent scan: don't divide by zero if there were no loops

Browse Source 
Commit 183b6a5361e040d7cc70c3b3391f43e0d126bc33 ("extent scan: refactor
BeesCrawl, BeesScanMode*") moved some statistics calculations out of
the loop in `find_next_extent`, but did not ensure that the statistics
would not be calculated if the loop had not executed any iterations.

In rare instances, the function returns without entering the loop at all,
which results in divide by zero.  Add a check just before doing that.

Signed-off-by: Zygo Blaxell <bees@furryterror.org>
This commit is contained in:
Zygo Blaxell 2025-02-13 23:41:31 -05:00
parent 51b3bcdbe4
commit a670aa5a71
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/bees-roots.cc
View File

@ -948,22 +948,24 @@ BeesScanModeExtent::SizeTier::find_next_extent()
const auto search_calls = BtrfsIoctlSearchKey::s_calls - init_s_calls; const auto search_calls = BtrfsIoctlSearchKey::s_calls - init_s_calls;
const auto search_loops = BtrfsIoctlSearchKey::s_loops - init_s_loops; const auto search_loops = BtrfsIoctlSearchKey::s_loops - init_s_loops;
if (crawl_time.age() > 1) { if (crawl_time.age() > 1) {
BEESLOGDEBUG( if (loop_count) {
"loop_count " << loop_count BEESLOGDEBUG(
<< " size_low_count " << size_low_count "loop_count " << loop_count
<< " size_high_count " << size_high_count << " size_low_count " << size_low_count
<< " gen_low_count " << gen_low_count << " size_high_count " << size_high_count
<< " gen_high_count " << gen_high_count << " gen_low_count " << gen_low_count
<< " search_calls " << search_calls << " gen_high_count " << gen_high_count
<< " search_loops " << search_loops << " search_calls " << search_calls
<< " skips " << skip_count << " search_loops " << search_loops
<< " flops " << flop_count << " skips " << skip_count
<< " time " << crawl_time << " flops " << flop_count
<< " subvol " << m_subvol << " time " << crawl_time
<< " search/loop " << pretty(search_calls / loop_count) << " subvol " << m_subvol
<< " skip/loop " << (100 * skip_count / loop_count) << "%" << " search/loop " << pretty(search_calls / loop_count)
<< " flop/loop " << (100 * flop_count / loop_count) << "%" << " skip/loop " << (100 * skip_count / loop_count) << "%"
); << " flop/loop " << (100 * flop_count / loop_count) << "%"
);
}
if (debug_oss) { if (debug_oss) {
BEESLOGDEBUG("debug oss trace:\n" << debug_oss->str()); BEESLOGDEBUG("debug oss trace:\n" << debug_oss->str());
} }