GGLinnk/bees
1
0
Fork 0
mirror of https://github.com/Zygo/bees.git synced 2025-05-17 21:35:45 +02:00
Code Packages

log: demote a lot of BEESLOGWARN to higher verbosity levels

Browse Source 
Toxic extent workarounds are going away because the underlying kernel
bugs have been fixed.  They are no longer worthy of spamming non-developer
logs.

INO_PATHS can return no paths if an inode has been deleted.  It doesn't
need a log message at all, much less one at WARN level.

Dedupe failure can be INFO, the same level as dedupe itself, especially
since the "NO dedupe" message doesn't mention what was [not] deduped.

Inspired by Kai Krakow's "context: demote "abandoned toxic match" to
debug log level".

Signed-off-by: Zygo Blaxell <bees@furryterror.org>
This commit is contained in:
Zygo Blaxell 2025-01-19 01:02:53 -05:00
parent aaec931081
commit a2b3e1e0c2
5 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/bees-context.cc
View File

@ -259,7 +259,7 @@ BeesContext::dedup(const BeesRangePair &brp_in)
BEESCOUNTADD(dedup_bytes, brp.first.size()); BEESCOUNTADD(dedup_bytes, brp.first.size());
} else { } else {
BEESCOUNT(dedup_miss); BEESCOUNT(dedup_miss);
BEESLOGWARN("NO Dedup! " << brp); BEESLOGINFO("NO Dedup! " << brp);
} }
lock.reset(); lock.reset();
@ -373,7 +373,7 @@ BeesContext::scan_one_extent(const BeesFileRange &bfr, const Extent &e)
Extent::OBSCURED | Extent::PREALLOC Extent::OBSCURED | Extent::PREALLOC
)) { )) {
BEESCOUNT(scan_interesting); BEESCOUNT(scan_interesting);
BEESLOGWARN("Interesting extent flags " << e << " from fd " << name_fd(bfr.fd())); BEESLOGINFO("Interesting extent flags " << e << " from fd " << name_fd(bfr.fd()));
} }
if (e.flags() & Extent::HOLE) { if (e.flags() & Extent::HOLE) {
@ -556,7 +556,7 @@ BeesContext::scan_one_extent(const BeesFileRange &bfr, const Extent &e)
BeesResolver resolved(m_ctx, found_addr); BeesResolver resolved(m_ctx, found_addr);
// Toxic extents are really toxic // Toxic extents are really toxic
if (resolved.is_toxic()) { if (resolved.is_toxic()) {
BEESLOGWARN("WORKAROUND: discovered toxic match at found_addr " << found_addr << " matching bbd " << bbd); BEESLOGDEBUG("WORKAROUND: discovered toxic match at found_addr " << found_addr << " matching bbd " << bbd);
BEESCOUNT(scan_toxic_match); BEESCOUNT(scan_toxic_match);
// Make sure we never see this hash again. // Make sure we never see this hash again.
// It has become toxic since it was inserted into the hash table. // It has become toxic since it was inserted into the hash table.
@ -917,7 +917,7 @@ BeesContext::scan_forward(const BeesFileRange &bfr_in)
// Sanity check // Sanity check
if (bfr.begin() >= bfr.file_size()) { if (bfr.begin() >= bfr.file_size()) {
BEESLOGWARN("past EOF: " << bfr); BEESLOGDEBUG("past EOF: " << bfr);
BEESCOUNT(scanf_eof); BEESCOUNT(scanf_eof);
return false; return false;
} }

2
src/bees-hash.cc
View File

@ -797,7 +797,7 @@ BeesHashTable::BeesHashTable(shared_ptr<BeesContext> ctx, string filename, off_t
for (auto fp = madv_flags; fp->value; ++fp) { for (auto fp = madv_flags; fp->value; ++fp) {
BEESTOOLONG("madvise(" << fp->name << ")"); BEESTOOLONG("madvise(" << fp->name << ")");
if (madvise(m_byte_ptr, m_size, fp->value)) { if (madvise(m_byte_ptr, m_size, fp->value)) {
BEESLOGWARN("madvise(..., " << fp->name << "): " << strerror(errno) << " (ignored)"); BEESLOGNOTICE("madvise(..., " << fp->name << "): " << strerror(errno) << " (ignored)");
} }
} }

4
src/bees-roots.cc
View File

@ -1990,7 +1990,7 @@ BeesRoots::open_root_ino_nocache(uint64_t root, uint64_t ino)
BEESTRACE("searching paths for root " << root << " ino " << ino); BEESTRACE("searching paths for root " << root << " ino " << ino);
Fd rv; Fd rv;
if (ipa.m_paths.empty()) { if (ipa.m_paths.empty()) {
BEESLOGWARN("No paths for root " << root << " ino " << ino); // BEESLOGDEBUG("No paths for root " << root << " ino " << ino);
BEESCOUNT(open_lookup_empty); BEESCOUNT(open_lookup_empty);
} }
BEESCOUNT(open_lookup_ok); BEESCOUNT(open_lookup_ok);
@ -2066,7 +2066,7 @@ BeesRoots::open_root_ino_nocache(uint64_t root, uint64_t ino)
int attr = ioctl_iflags_get(rv); int attr = ioctl_iflags_get(rv);
if (attr & FS_NOCOW_FL) { if (attr & FS_NOCOW_FL) {
BEESLOGWARN("Opening " << name_fd(rv) << " found FS_NOCOW_FL flag in " << to_hex(attr)); BEESLOGINFO("Opening " << name_fd(rv) << " found FS_NOCOW_FL flag in " << to_hex(attr));
rv = Fd(); rv = Fd();
BEESCOUNT(open_wrong_flags); BEESCOUNT(open_wrong_flags);
break; break;

4
src/bees-types.cc
View File

@ -457,7 +457,7 @@ BeesRangePair::grow(shared_ptr<BeesContext> ctx, bool constrained)
} }
} }
if (found_toxic) { if (found_toxic) {
BEESLOGWARN("WORKAROUND: found toxic hash in " << first_bbd << " while extending backward:\n" << *this); BEESLOGDEBUG("WORKAROUND: found toxic hash in " << first_bbd << " while extending backward:\n" << *this);
BEESCOUNT(pairbackward_toxic_hash); BEESCOUNT(pairbackward_toxic_hash);
break; break;
} }
@ -558,7 +558,7 @@ BeesRangePair::grow(shared_ptr<BeesContext> ctx, bool constrained)
} }
} }
if (found_toxic) { if (found_toxic) {
BEESLOGWARN("WORKAROUND: found toxic hash in " << first_bbd << " while extending forward:\n" << *this); BEESLOGDEBUG("WORKAROUND: found toxic hash in " << first_bbd << " while extending forward:\n" << *this);
BEESCOUNT(pairforward_toxic_hash); BEESCOUNT(pairforward_toxic_hash);
break; break;
} }

2
src/bees.cc
View File

@ -198,7 +198,7 @@ BeesTooLong::check() const
if (age() > m_limit) { if (age() > m_limit) {
ostringstream oss; ostringstream oss;
m_func(oss); m_func(oss);
BEESLOGWARN("PERFORMANCE: " << *this << " sec: " << oss.str()); BEESLOGINFO("PERFORMANCE: " << *this << " sec: " << oss.str());
} }
} }