GGLinnk/bees
1
0
Fork 0
mirror of https://github.com/Zygo/bees.git synced 2025-05-17 13:25:45 +02:00
Code Packages

stats: remove nonsense dedup_unique_bytes stat

Browse Source 
A long time ago, when bees used dedicated threads to scan each subvol, the
calculation of the "dedup_unique_bytes" statistic was still wrong.

This stat can only be calculated when dedupe runs on extent data items
instead of extent reference items.  Remove the stat variable until
that happens.

Signed-off-by: Zygo Blaxell <bees@furryterror.org>
This commit is contained in:
Zygo Blaxell 2020-12-13 13:46:29 -05:00
parent 1b9b437c11
commit 8e9b53b3fd
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/event-counters.md
View File

@ -151,7 +151,6 @@ The `dedup` event group consists of operations that deduplicate data.
* `dedup_prealloc_hit`: Total number of successfully eliminated `PREALLOC` extent references. * `dedup_prealloc_hit`: Total number of successfully eliminated `PREALLOC` extent references.
* `dedup_prealloc_hit`: Total number of unsuccessfully eliminated `PREALLOC` extent references (i.e. filesystem data changed between scan and dedupe). * `dedup_prealloc_hit`: Total number of unsuccessfully eliminated `PREALLOC` extent references (i.e. filesystem data changed between scan and dedupe).
* `dedup_try`: Total number of pairs of extent references submitted for deduplication. * `dedup_try`: Total number of pairs of extent references submitted for deduplication.
* `dedup_unique_bytes`: Total bytes in extent data items deduplicated. The implementation of this counter is wrong.
* `dedup_workaround_btrfs_send`: Total number of extent reference pairs submitted for deduplication that were discarded to workaround `btrfs send` bugs. * `dedup_workaround_btrfs_send`: Total number of extent reference pairs submitted for deduplication that were discarded to workaround `btrfs send` bugs.
exception exception

5
src/bees-context.cc
View File

@ -258,11 +258,6 @@ BeesContext::dedup(const BeesRangePair &brp)
if (rv) { if (rv) {
BEESCOUNT(dedup_hit); BEESCOUNT(dedup_hit);
BEESCOUNTADD(dedup_bytes, brp.first.size()); BEESCOUNTADD(dedup_bytes, brp.first.size());
thread_local BeesFileRange last_src_bfr;
if (!last_src_bfr.overlaps(brp.first)) {
BEESCOUNTADD(dedup_unique_bytes, brp.first.size());
last_src_bfr = brp.first;
}
} else { } else {
BEESCOUNT(dedup_miss); BEESCOUNT(dedup_miss);
BEESLOGWARN("NO Dedup! " << brp); BEESLOGWARN("NO Dedup! " << brp);