From 59fe9f46174b28912ff15f0e95f575d233ef6e9b Mon Sep 17 00:00:00 2001 From: Zygo Blaxell Date: Sat, 16 Sep 2017 16:35:42 -0400 Subject: [PATCH] bees: drop unused BeesWorkQueue classes Signed-off-by: Zygo Blaxell --- src/bees-context.cc | 106 -------------------------------------------- src/bees.h | 36 --------------- 2 files changed, 142 deletions(-) diff --git a/src/bees-context.cc b/src/bees-context.cc index e2ea939..10f425d 100644 --- a/src/bees-context.cc +++ b/src/bees-context.cc @@ -73,97 +73,6 @@ BeesFdCache::insert_root_ino(shared_ptr ctx, Fd fd) return m_file_cache.insert(fd, ctx, fid.root(), fid.ino()); } -mutex BeesWorkQueueBase::s_mutex; -set BeesWorkQueueBase::s_all_workers; - -BeesWorkQueueBase::BeesWorkQueueBase(const string &name) : - m_name(name) -{ -} - -BeesWorkQueueBase::~BeesWorkQueueBase() -{ - unique_lock lock(s_mutex); - s_all_workers.erase(this); -} - -void -BeesWorkQueueBase::for_each_work_queue(std::function f) -{ - unique_lock lock(s_mutex); - for (auto i : s_all_workers) { - f(i); - } -} - -string -BeesWorkQueueBase::name() const -{ - return m_name; -} - -void -BeesWorkQueueBase::name(const string &new_name) -{ - m_name = new_name; -} - -template -BeesWorkQueue::~BeesWorkQueue() -{ -} - -template -BeesWorkQueue::BeesWorkQueue(const string &name) : - BeesWorkQueueBase(name) -{ - unique_lock lock(s_mutex); - s_all_workers.insert(this); -} - -template -void -BeesWorkQueue::push_active(const Task &t) -{ - BEESNOTE("pushing task " << t); - m_active_queue.push(t); -} - -template -void -BeesWorkQueue::push_active(const Task &t, size_t limit) -{ - // BEESNOTE("pushing limit " << limit << " task " << t); - m_active_queue.push_wait(t, limit); -} - -template -size_t -BeesWorkQueue::active_size() const -{ - return m_active_queue.size(); -} - -template -list -BeesWorkQueue::peek_active(size_t count) const -{ - list rv; - for (auto i : m_active_queue.peek(count)) { - ostringstream oss; - oss << i; - rv.push_back(oss.str()); - } - return rv; -} - -template -Task -BeesWorkQueue::pop() -{ - return m_active_queue.pop(); -} - void BeesContext::dump_status() { @@ -190,12 +99,6 @@ BeesContext::dump_status() ofs << "\ttid " << t.first << ": " << t.second << "\n"; } - BeesWorkQueueBase::for_each_work_queue([&](BeesWorkQueueBase *worker) { - ofs << "QUEUE: " << worker->name() << " active: " << worker->active_size() << "\n"; - for (auto t : worker->peek_active(10)) { - ofs << "\t" << t << "\n"; - } - }); ofs.close(); BEESNOTE("renaming status file '" << status_file << "'"); @@ -231,10 +134,6 @@ BeesContext::show_progress() }; lastProgressStats = thisStats; - BeesWorkQueueBase::for_each_work_queue([&](BeesWorkQueueBase *worker) { - BEESLOG("QUEUE: " << worker->name() << " active: " << worker->active_size()); - }); - BEESLOG("THREADS:"); for (auto t : BeesNote::get_status()) { @@ -1054,8 +953,3 @@ BeesContext::insert_root_ino(Fd fd) { fd_cache()->insert_root_ino(shared_from_this(), fd); } - -// instantiate templates for linkage ---------------------------------------- - -template class BeesWorkQueue; -template class BeesWorkQueue; diff --git a/src/bees.h b/src/bees.h index 861e965..ce16ced 100644 --- a/src/bees.h +++ b/src/bees.h @@ -602,42 +602,6 @@ public: friend ostream & operator<<(ostream &os, const BeesRangePair &brp); }; -class BeesWorkQueueBase { - string m_name; - -protected: - static mutex s_mutex; - static set s_all_workers; - -public: - virtual ~BeesWorkQueueBase(); - BeesWorkQueueBase(const string &name); - - string name() const; - void name(const string &new_name); - - virtual size_t active_size() const = 0; - virtual list peek_active(size_t count) const = 0; - - static void for_each_work_queue(function f); -}; - -template -class BeesWorkQueue : public BeesWorkQueueBase { - WorkQueue m_active_queue; - -public: - BeesWorkQueue(const string &name); - ~BeesWorkQueue(); - void push_active(const Task &task, size_t limit); - void push_active(const Task &task); - - size_t active_size() const override; - list peek_active(size_t count) const override; - - Task pop(); -}; - class BeesTempFile { shared_ptr m_ctx; Fd m_fd;