From 44810d6df871e60a543b44b9f744178851391e3d Mon Sep 17 00:00:00 2001 From: Zygo Blaxell Date: Fri, 29 Nov 2024 19:22:53 -0500 Subject: [PATCH] scan_one_extent: remove the unreadahead after benchmark results That unreadahead used to result in a 10% hit on benchmarks. Now it's closer to 75%. Signed-off-by: Zygo Blaxell --- src/bees-context.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bees-context.cc b/src/bees-context.cc index e259b21..194c124 100644 --- a/src/bees-context.cc +++ b/src/bees-context.cc @@ -839,8 +839,8 @@ BeesContext::scan_one_extent(const BeesFileRange &bfr, const Extent &e) } lock_seen.unlock(); - // Still hurts benchmarks...or does it? - bees_unreadahead(bfr.fd(), bfr.begin(), bfr.size()); + // Now causes 75% loss of performance in benchmarks + // bees_unreadahead(bfr.fd(), bfr.begin(), bfr.size()); } shared_ptr