From 4417b18d9e538d100d0a7f1136f7f1691a9f975a Mon Sep 17 00:00:00 2001 From: Kai Krakow Date: Sun, 21 Jan 2018 03:17:40 +0100 Subject: [PATCH] Makefile: .version.o is made from a generated file We should probably not put it into the objects list. Let's instead explicitly put it as a depend of libcrucible.so. This allows us to not use *.cc as a depend for .version.cc which makes more sense as CRUCIBLE_OBJS is also explicitly defined and not built from wildcards. Signed-off-by: Kai Krakow --- lib/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index 3217578..57e0cb9 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -18,9 +18,8 @@ CRUCIBLE_OBJS = \ task.o \ time.o \ uuid.o \ - .version.o \ -libcrucible.so: $(CRUCIBLE_OBJS) -luuid +libcrucible.so: $(CRUCIBLE_OBJS) .version.o -luuid include ../makeflags include ../Defines.mk @@ -36,7 +35,7 @@ depends.mk: $(CRUCIBLE_OBJS:%.o=.depends/%.dep) cat $^ > $@.new mv -f $@.new $@ -.version.cc: configure.h Makefile ../makeflags *.cc ../include/crucible/*.h +.version.cc: configure.h Makefile ../makeflags $(CRUCIBLE_OBJS:.o=.cc) ../include/crucible/*.h echo "namespace crucible { const char *VERSION = \"$(TAG)\"; }" > $@.new mv -f $@.new $@