From 31f3a8d67d2fe3b5145976d75d64004bc32f4ca6 Mon Sep 17 00:00:00 2001 From: Zygo Blaxell Date: Thu, 12 Dec 2024 22:56:48 -0500 Subject: [PATCH] progress: relabel the inaccurate ETA column ETA is calculated using a sample obtained by snooping on bees's normal crawling operations. This sample is heavily biased and not representative of the entire filesystem. If the distribution of extent sizes in the filesystem is not uniform, the ETA can be wildly wrong. Collecting an accurate sample set would require extra IO and CPU time which should be spent doing dedupes instead. Explicitly label the ETA as inaccurate to avoid having too many users report the same bug. Signed-off-by: Zygo Blaxell --- src/bees-roots.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bees-roots.cc b/src/bees-roots.cc index cd96636..3895927 100644 --- a/src/bees-roots.cc +++ b/src/bees-roots.cc @@ -1078,7 +1078,7 @@ BeesScanModeExtent::next_transid(const CrawlMap &crawl_map_unused) Table::Text("transid"), Table::Number(m_roots->transid_max()), Table::Text("todo"), - Table::Text("ETA"), + Table::Text("inaccurate ETA"), }); const auto dash_fill = Table::Fill('-'); eta.insert_row(1, vector(eta.cols().size(), dash_fill));